Skip to content

Minor vector sizing change. #10753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
+4 −4
Merged

Minor vector sizing change. #10753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions backends/vulkan/runtime/vk_api/Descriptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ DescriptorSet& DescriptorSet::bind(

VkDescriptorSet DescriptorSet::get_bind_handle() const {
std::vector<VkWriteDescriptorSet> write_descriptor_sets;
write_descriptor_sets.reserve(bindings_.size());

for (const ResourceBinding& binding : bindings_) {
VkWriteDescriptorSet write{
Expand Down Expand Up @@ -185,9 +186,7 @@ VkDescriptorSet DescriptorSet::get_bind_handle() const {
0u,
nullptr);

VkDescriptorSet ret = handle_;

return ret;
return handle_;
}

void DescriptorSet::add_binding(const ResourceBinding& binding) {
Expand Down
3 changes: 2 additions & 1 deletion backends/vulkan/runtime/vk_api/Shader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,11 @@ ShaderLayout::ShaderLayout(
const ShaderLayout::Signature& signature)
: device_(device), handle_{VK_NULL_HANDLE} {
std::vector<VkDescriptorSetLayoutBinding> bindings;
bindings.reserve(signature.size());

uint32_t binding_num = 0u;
for (const VkDescriptorType type : signature) {
bindings.push_back({
bindings.emplace_back(VkDescriptorSetLayoutBinding{
binding_num++, // binding
type, // descriptorType
1u, // descriptorCount
Expand Down
Loading