word_language_model: Fix Transformer init_weights #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model was not getting initialized property since it was using the decoder object instead of decoder weight to initialize zeros. Signed-off-by: Eli Uriegas <[email protected]>
vishwakftw
approved these changes
Jun 15, 2020
Contributor
vishwakftw
left a comment
vishwakftw
left a comment
There was a problem hiding this comment.
Looks good to me, thanks.
The blame is attributed to me due to #767.
YinZhengxun
pushed a commit
to YinZhengxun/mt-exercise-02
that referenced
this pull request
Mar 30, 2025
word_language_model: Fix Transformer init_weights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model was not getting initialized property since it was using the
decoder object instead of decoder weight to initialize zeros.
Closes #783
Solution can be attributed to @mjoukamaa
Signed-off-by: Eli Uriegas [email protected]