Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

so people don't try to run the commands in the container's bash #444

Merged
merged 1 commit into from
May 18, 2020
Merged

so people don't try to run the commands in the container's bash #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manywheel/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ OR
nvidia-docker run -it --ipc=host --rm -v $(pwd):/remote soumith/manylinux-cuda100:latest bash
```

Then run:
Exit the container, then back in the host, run:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayenashar I know this is an old PR, but I'm trying to follow the instructions and the logic, and don't understand... if I run the nvidia-ducker run -it above, and then "exit the container", what's the point of running the docker run? since it isn't detached, exiting it will simply stop the container... furthermore, it seems that the logic in here actually starts another container anyway, so I'm confused about this

builder/cron/build_docker.sh

Lines 120 to 127 in 52c2f25

# Image
docker_args+=" ${docker_image}"
##############################################################################
# We start a container and detach it such that we can run
# a series of commands without nuking the container
echo "Starting container for image ${docker_image}"
id=$(nvidia-docker run ${docker_args} /bin/cat)

perhaps the instructions are outdated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't recall and i've given up on building pytorch packages, but i would guess it's to pre-download the image. i didn't write lines 11-13 so i really don't know. you may also notice the --rm which will remove the stopped container.


```
# versioned, build all
Expand Down