fixed documentation example for model.condition_on_observations. #2978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80371177 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 216 216
Lines 20310 20310
=========================================
Hits 20310 20310 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ethche
pushed a commit
to ethche/botorch
that referenced
this pull request
Aug 15, 2025
…orch#2978) Summary: As pointed out in [issue pytorch#2446](pytorch#2446) the example for model.condition_on_observations is outdated and raises an error when run. The docstring is now updated with proper usage of the method. Reviewed By: Balandat Differential Revision: D80371177
ethche
force-pushed
the
export-D80371177
branch
from
81e7926 to
bf5b607
Compare
…orch#2978) Summary: Pull Request resolved: pytorch#2978 As pointed out in [issue pytorch#2446](pytorch#2446) the example for model.condition_on_observations is outdated and raises an error when run. The docstring is now updated with proper usage of the method. Reviewed By: Balandat Differential Revision: D80371177
|
This pull request was exported from Phabricator. Differential Revision: D80371177 |
ethche
force-pushed
the
export-D80371177
branch
from
bf5b607 to
739cd4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As pointed out in issue #2446 the example for model.condition_on_observations is outdated and raises an error when run. The docstring is now updated with proper usage of the method.
Differential Revision: D80371177