log values for HVKG using LogEHVI #2974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80263869 |
ethche
force-pushed
the
export-D80263869
branch
from
bf7a89b to
b447004
Compare
ethche
pushed a commit
to ethche/botorch
that referenced
this pull request
Aug 14, 2025
Summary: HKVG to output log values when _log=True using the LogEHVI value function. Also adds a _log flag to InverseCostWeightedUtility to output utilities in log-space. if _log=True, it assumes that * current_value is in log-space * cost_aware_utility outputs in log-space (raises an error if cost_aware_utility does not have a _log flag or if its _log=False). Note that InverseCostWeightedUtility does a logarithmic transform for the inputted costs; assumes that inputted costs are in the original space. This is so that one does not need to make any direct modification to the cost fn, and because InverseCostWeightedUtility already does some pre-processing to the costs (e.g. clipping). tldr: HKVG assumes all of its inputs are logged, but InverseCostWeightedUtility does not. Differential Revision: D80263869
|
This pull request was exported from Phabricator. Differential Revision: D80263869 |
ethche
force-pushed
the
export-D80263869
branch
from
b447004 to
4b944e0
Compare
ethche
pushed a commit
to ethche/botorch
that referenced
this pull request
Aug 14, 2025
Summary: HKVG to output log values when _log=True using the LogEHVI value function. Also adds a _log flag to InverseCostWeightedUtility to output utilities in log-space. if _log=True, it assumes that * current_value is in log-space * cost_aware_utility outputs in log-space (raises an error if cost_aware_utility does not have a _log flag or if its _log=False). Note that InverseCostWeightedUtility does a logarithmic transform for the inputted costs; assumes that inputted costs are in the original space. This is so that one does not need to make any direct modification to the cost fn, and because InverseCostWeightedUtility already does some pre-processing to the costs (e.g. clipping). tldr: HKVG assumes all of its inputs are logged, but InverseCostWeightedUtility does not. Differential Revision: D80263869
|
This pull request was exported from Phabricator. Differential Revision: D80263869 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2974 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 216 216
Lines 20294 20310 +16
=========================================
+ Hits 20294 20310 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ethche
pushed a commit
to ethche/botorch
that referenced
this pull request
Aug 14, 2025
Summary: HKVG to output log values when _log=True using the LogEHVI value function. Also adds a _log flag to InverseCostWeightedUtility to output utilities in log-space. if _log=True, it assumes that * current_value is in log-space * cost_aware_utility outputs in log-space (raises an error if cost_aware_utility does not have a _log flag or if its _log=False). Note that InverseCostWeightedUtility does a logarithmic transform for the inputted costs; assumes that inputted costs are in the original space. This is so that one does not need to make any direct modification to the cost fn, and because InverseCostWeightedUtility already does some pre-processing to the costs (e.g. clipping). tldr: HKVG assumes all of its inputs are logged, but InverseCostWeightedUtility does not. Reviewed By: SebastianAment Differential Revision: D80263869
ethche
force-pushed
the
export-D80263869
branch
from
4b944e0 to
02bb001
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80263869 |
Summary: HKVG to output log values when _log=True using the LogEHVI value function. Also adds a _log flag to InverseCostWeightedUtility to output utilities in log-space. if _log=True, it assumes that * current_value is in log-space * cost_aware_utility outputs in log-space (raises an error if cost_aware_utility does not have a _log flag or if its _log=False). Note that InverseCostWeightedUtility does a logarithmic transform for the inputted costs; assumes that inputted costs are in the original space. This is so that one does not need to make any direct modification to the cost fn, and because InverseCostWeightedUtility already does some pre-processing to the costs (e.g. clipping). tldr: HKVG assumes all of its inputs are logged, but InverseCostWeightedUtility does not. Reviewed By: SebastianAment Differential Revision: D80263869
ethche
force-pushed
the
export-D80263869
branch
from
02bb001 to
510dfc5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80263869 |
|
This pull request has been merged in b1097c6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
HKVG to output log values when _log=True using the LogEHVI value function.
Also adds a _log flag to InverseCostWeightedUtility to output utilities in log-space.
if _log=True, it assumes that
Note that InverseCostWeightedUtility does a logarithmic transform for the inputted costs; assumes that inputted costs are in the original space. This is so that one does not need to make any direct modification to the cost fn, and because InverseCostWeightedUtility already does some pre-processing to the costs (e.g. clipping).
tldr: HKVG assumes all of its inputs are logged, but InverseCostWeightedUtility does not.
Rollback Plan:
Differential Revision: D80263869