Switch to CMake-based build #986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
libtorchaudio-pr
branch
from
af7a1db to
34c7345
Compare
mthrok
force-pushed
the
libtorchaudio-pr
branch
from
be15a6a to
0a18ac6
Compare
cpuhrsch
reviewed
Dec 1, 2020
CMakeLists.txt
Outdated
| set(CMAKE_CXX_STANDARD 14 CACHE STRING "The C++ standard whose features are requested to build this target.") | ||
|
|
||
| find_package(Torch REQUIRED) | ||
| # TORCH_CXX_FLAGS contains proper _GLIBCXX_USE_CXX11_ABI |
There was a problem hiding this comment.
You can add a reference to the issue and a bit more color
cpuhrsch
reviewed
Dec 1, 2020
vincentqb
reviewed
Dec 1, 2020
cpuhrsch
reviewed
Dec 1, 2020
| set(envs "PKG_CONFIG_PATH=${INSTALL_DIR}/lib/pkgconfig" "LDFLAGS=-L${INSTALL_DIR}/lib $ENV{LDFLAGS}" "CPPFLAGS=-I${INSTALL_DIR}/include $ENV{CPPFLAGS}" "CXXFLAGS=${TORCH_CXX_FLAGS} $ENV{CXXFLAGS}") | ||
|
|
||
|
|
||
| ExternalProject_Add(mad_ |
There was a problem hiding this comment.
As a follow-up, we could eventually use submodules
|
Closing as the commit history gets very convoluted |
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
Update RPC link, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to #1068