Fixing clang-format version to what PyTorch uses. #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
commented
Oct 22, 2020
Contributor
Author
datumbox
left a comment
datumbox
left a comment
There was a problem hiding this comment.
Left some comments to clarify changes, please have a look.
| install_build_dependencies() { | ||
| printf "* Installing torchaudio dependencies except PyTorch - (Python: %s)\n" "$1" | ||
| conda env update -q --file "${_this_dir}/environment.yml" --prune | ||
| if [ "${_os}" == Linux ]; then |
Contributor
Author
There was a problem hiding this comment.
I believe clang-format is not actually used in the specific tests, so I removed it.
| conda env update --file "${this_dir}/environment.yml" --prune | ||
| if [ "${os}" == Linux ] ; then | ||
| pip install clang-format | ||
| clangformat_path="${root_dir}/clang-format" |
Contributor
Author
There was a problem hiding this comment.
As far as I understand other libraries like conda are put directly in root. So I do the same with clang-format.
|
|
||
| printf "\x1b[34mRunning clang-format: " | ||
| clang-format --version | ||
| ./clang-format --version |
Contributor
Author
There was a problem hiding this comment.
Our root_dir is ./ here. Similar to what we do above with conda.
Contributor
Author
|
The failed test are unrelated so we agreed with @mthrok to merge. Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vision-2372 we fixed the clang-format version. @mthrok proposed to do the same in audio.