Skip to content

Update package script to use UPLOAD_CHANNEL env #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

Update package script to use UPLOAD_CHANNEL env #962

merged 1 commit into from
Oct 16, 2020

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Oct 15, 2020

Following the review on pytorch/text#1037, apply the same change on torchaudio.

Note: This commit should also go to release branch.

@mthrok mthrok requested a review from seemethere October 15, 2020 21:18
vincentqb
vincentqb approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit ba00419 into pytorch:master Oct 16, 2020
@mthrok mthrok deleted the tweak-packaging branch October 16, 2020 16:06
@mthrok
Copy link
Contributor Author

mthrok commented Oct 16, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

+1 more reviewer

@vincentqb vincentqb vincentqb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mthrok @seemethere @vincentqb