Resolve setup issue of macOS CI Unittest on release/0.7 #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
fix-macos-ci
branch
2 times, most recently
from
6484e7a to
26c2d25
Compare
Contributor
|
If pytorch supported python 3.9 in 1.7 release (unfortunately doesn't, here), we could see if 3.9 also works, and this could give us some indication that issue may have been resolved on python side? |
mthrok
changed the title
Contributor
cpuhrsch
approved these changes
Oct 19, 2020
vincentqb
approved these changes
Oct 19, 2020
Contributor
vincentqb
left a comment
vincentqb
left a comment
There was a problem hiding this comment.
As I understand, this essentially disables caching on the branch release. LGTM.
Contributor
Author
|
thanks |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Shen Li <[email protected]> Co-authored-by: holly1238 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves dependency issue of macOS unit test job setup step on
release/0.7branch.It turns out that on macOS and Python 3.6 and 3.7
sox_effects.apply_effects_tensorandsox_effects.apply_effects_fileget stuck when used in DataLoader with multiple workers.Looks like it is related to
OMP_NUM_THREADSand DataLoader. Filed the issue here -> pytorch/pytorch#46409 .However notice that the way the CI jobs for PRs set up restricts to use PyTorch nightly build.They might not be issue if the tests are ran with PyTorch RC 1.7.0. So I suggest to merge this PR first and let the CI job for
release/0.7run and see if the stuck still happens. Then resolve it in the later PR.