Skip to content

Add deprecation warning to sox backend #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Add deprecation warning to sox backend #904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfbb043
Add deprecation warning to sox backend
mthrok Sep 10, 2020
f2d741b
Update based on the review
mthrok Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions torchaudio/backend/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ def set_audio_backend(backend: Optional[str]):
if backend is None:
module = no_backend
elif backend == 'sox':
warnings.warn(
'"sox" backend is being deprecated. '
'The default backend will be changed to "sox_io" backend in 0.8.0 and '
'"sox" backend will be removed in 0.9.0. Please migrate to "sox_io" backend. '
'Please refer to https://github.com/pytorch/audio/issues/903 for the detail.')
module = sox_backend
elif backend == 'sox_io':
module = sox_io_backend
Expand Down