Add wsj0mix dataset #895
Merged
Add wsj0mix dataset #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
conv-tasnet-wsj0mix
branch
2 times, most recently
from
f4186b6 to
e368349
Compare
mthrok
force-pushed
the
conv-tasnet-wsj0mix
branch
from
e368349 to
a7f0e2a
Compare
vincentqb
reviewed
Sep 10, 2020
Contributor
|
as mentioned here, training on an open dataset like LibriMix would allow for more users to experiment with the dataset |
mthrok
force-pushed
the
conv-tasnet-wsj0mix
branch
from
ace5b6b to
c871382
Compare
mthrok
force-pushed
the
conv-tasnet-wsj0mix
branch
2 times, most recently
from
51f83e3 to
8763416
Compare
mthrok
force-pushed
the
conv-tasnet-wsj0mix
branch
from
8763416 to
89c1c67
Compare
vincentqb
reviewed
Oct 12, 2020
Comment on lines
+39
to
+46
| def _load_audio(self, path) -> torch.Tensor: | ||
| waveform, sample_rate = torchaudio.load(path) | ||
| if sample_rate != self.sample_rate: | ||
| raise ValueError( | ||
| f"The dataset contains audio file of sample rate {sample_rate}. " | ||
| "Where the requested sample rate is {self.sample_rate}." | ||
| ) | ||
| return waveform |
Contributor
There was a problem hiding this comment.
What does this function serve beyond wrapping load? Ensures sample rate is the same?
cpuhrsch
approved these changes
Oct 12, 2020
vincentqb
reviewed
Oct 12, 2020
|
|
||
| from . import wsj0mix | ||
|
|
||
| Batch = namedtuple("Batch", ["mix", "src", "mask"]) |
vincentqb
approved these changes
Oct 12, 2020
Contributor
vincentqb
left a comment
vincentqb
left a comment
There was a problem hiding this comment.
Minor comments, but LGTM
cpuhrsch
reviewed
Oct 12, 2020
| self.root = Path(root) | ||
| self.sample_rate = sample_rate | ||
| self.mix_dir = (self.root / "mix").resolve() | ||
| self.src_dirs = [(self.root / f"s{i+1}").resolve() for i in range(num_speakers)] |
Contributor
There was a problem hiding this comment.
nit: could use os path join
Contributor
Author
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#897
test/torchaudio_unittest