Skip to content

Conversation

@jimchen90
Copy link
Contributor

@jimchen90 jimchen90 commented Aug 4, 2020

This is to add the first part of tacotron2 model.

@vincentqb
Copy link
Contributor

It's the first part of tacotron 2, right? and it builds on top of #835 and #844, right?

@jimchen90
Copy link
Contributor Author

It's the first part of tacotron 2, right? and it builds on top of #835 and #844, right?

Yes, this is the first part of tacotron 2. And it is a separate one.


return outputs

def infer(self, x: Tensor, input_lengths: Tensor) -> Tensor:
Copy link
Contributor

@vincentqb vincentqb Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference with forward here?

Having an "infer" method would be a new convention, so we need to be careful before adding it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference here is the dropout layer. I agree, since the "infer" won't be used in the training, I will remove this part.


return mel_outputs, gate_outputs, alignments

def infer(self, memory: Tensor, memory_lengths: Tensor) -> Tuple[Tensor]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

[mel_outputs, mel_outputs_postnet, gate_outputs, alignments], output_lengths
)

def infer(self, inputs: Tensor, input_lengths: Tensor) -> Tuple[Tensor]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@facebook-github-bot
Copy link
Contributor

Hi @jimchen90!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@yangarbiter
Copy link
Contributor

yangarbiter commented Jul 6, 2021

Continuing this feature in #1621.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants