-
Notifications
You must be signed in to change notification settings - Fork 739
Generate YESNO dataset on-the-fly for test #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
==========================================
+ Coverage 89.78% 89.82% +0.03%
==========================================
Files 34 34
Lines 2654 2654
==========================================
+ Hits 2383 2384 +1
+ Misses 271 270 -1
Continue to review full report at Codecov.
|
| if 'sox' in BACKENDS: | ||
| be = 'sox' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this is removing "sox" from "set_audio_backend"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it's changing the default backend to be sox_io when it's available.
vincentqb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
cc @jimchen90 for visibility |
Adding Batch RPC example
Part of #764