Skip to content

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Jul 16, 2020

Part of #764

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #792 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
+ Coverage   89.78%   89.82%   +0.03%     
==========================================
  Files          34       34              
  Lines        2654     2654              
==========================================
+ Hits         2383     2384       +1     
+ Misses        271      270       -1     
Impacted Files Coverage Δ
torchaudio/datasets/yesno.py 80.43% <0.00%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b898f...7626b72. Read the comment docs.

@mthrok mthrok marked this pull request as ready for review July 16, 2020 21:24
@mthrok mthrok mentioned this pull request Jul 16, 2020
14 tasks
@mthrok mthrok requested a review from vincentqb July 16, 2020 21:26
Comment on lines -32 to -33
if 'sox' in BACKENDS:
be = 'sox'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this is removing "sox" from "set_audio_backend"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's changing the default backend to be sox_io when it's available.

Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentqb
Copy link
Contributor

cc @jimchen90 for visibility

@mthrok mthrok merged commit 102174e into pytorch:master Jul 16, 2020
@mthrok mthrok deleted the test-yesno branch July 16, 2020 22:54
@jimchen90 jimchen90 mentioned this pull request Jul 17, 2020
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants