Skip to content

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Jul 13, 2020

Circle CI can display coverage report nicely.
Doc: https://circleci.com/docs/2.0/code-coverage/
https://201041-90321822-gh.circle-artifacts.com/0/test/htmlcov/index.html

This way, we can get rid of codecov, yet can have coverage report available all the time.
Thoughts? @fmassa @cpuhrsch

@mthrok mthrok marked this pull request as ready for review July 13, 2020 22:24
@mthrok mthrok mentioned this pull request Jul 14, 2020
@mthrok mthrok force-pushed the coverage branch 4 times, most recently from a0bbde3 to ea3f9f4 Compare July 20, 2020 22:28
@mthrok mthrok force-pushed the coverage branch 2 times, most recently from 221f6f1 to d595347 Compare July 30, 2020 19:36
@mthrok mthrok requested review from fmassa and parmeet April 19, 2021 21:05
@mthrok mthrok changed the title Store coverage on CCI Remove codecov and store coverage on CCI Apr 19, 2021
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach LGTM, thanks Moto!

I'd be happy to have the same be applied in torchvision

@mthrok mthrok merged commit f177a8d into pytorch:master Apr 20, 2021
@mthrok mthrok deleted the coverage branch April 20, 2021 14:30
carolineechen pushed a commit to carolineechen/audio that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants