Skip to content

Conversation

@jimchen90
Copy link
Contributor

@jimchen90 jimchen90 commented Jul 13, 2020

Offer WaveRNN model with pretrained weights (8 bits waveform mode) on LJSpeech using the method as torchvision example.

Related to #735 #749
Internal

@jimchen90 jimchen90 requested a review from vincentqb July 13, 2020 12:28
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #776 into master will decrease coverage by 0.21%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
- Coverage   89.53%   89.31%   -0.22%     
==========================================
  Files          32       33       +1     
  Lines        2617     2629      +12     
==========================================
+ Hits         2343     2348       +5     
- Misses        274      281       +7     
Impacted Files Coverage Δ
torchaudio/models/_wavernn.py 94.06% <44.44%> (-4.12%) ⬇️
torchaudio/models/utils.py 50.00% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26941fa...84a8831. Read the comment docs.



model_urls = {
'_wavernn': 'https://download.pytorch.org/models/_wavernn.pth',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's conventional to add a FIXME comment here

    # FIXME Replace URL by final one once determined
    '_wavernn': 'https://download.pytorch.org/models/_wavernn.pth',

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: once you know the actual URL, you can add it here without the underscore in the URL :)

@vincentqb vincentqb mentioned this pull request Jul 13, 2020
2 tasks
@jimchen90 jimchen90 marked this pull request as ready for review July 15, 2020 18:20
@PetrochukM
Copy link

PetrochukM commented Jul 15, 2020

Has Linda Johnson consented to voice cloning? Without consent from Linda Johnson, this risks infringing on her personality rights, I think. This could also infringe on her "right to privacy" (the right to be left alone) or "likeness rights".

The dataset website does not mention that Linda Johnson was involved in the decision-making process for creating this dataset. I think it'd be important to consider Linda Johnson's perspective before distributing a clone of her voice to the public! Thank you!

@jimchen90
Copy link
Contributor Author

jimchen90 commented Jul 15, 2020

Has Linda Johnson consented to voice cloning? Unless you get consent from Linda Johnson, you risk infringing on her personality rights: https://en.wikipedia.org/wiki/Personality_rights

Linda Johnson as not agreed to license her voice, at least the dataset does not give any indication that she has.

Please consider Linda Johnson's personal rights before distributing a clone of her voice to the public! Thank you!

Thank you @PetrochukM for the input! Let me bring @keithito to this discussion.

@keithito -- I'm planning to offer pre-trained weights for a WaveRNN model based on LJSpeech in torchaudio. Can you add clarity about whether the license of this dataset allows doing so? Thank you!

cc @soumith @vincentqb @astaff @dongreenberg

@keithito
Copy link

Hi @jimchen90, all text and audio in the LJ Speech Dataset is in the public domain. For more information, please see these resources from LibriVox, the project that originally released the recordings:

I have personally corresponded with Linda (the voice actor who read the audiobooks), and she has been very supportive of having her recordings used as the basis of a public domain speech dataset.

@facebook-github-bot
Copy link
Contributor

Hi @jimchen90!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@discort
Copy link
Contributor

discort commented May 23, 2021

@jimchen90 @vincentqb

Thanks for working on it. Is any ETA?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yangarbiter
Copy link
Contributor

Continuing this feature in #1612.

mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants