-
Notifications
You must be signed in to change notification settings - Fork 739
Offer pretrained wavernn model #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
==========================================
- Coverage 89.53% 89.31% -0.22%
==========================================
Files 32 33 +1
Lines 2617 2629 +12
==========================================
+ Hits 2343 2348 +5
- Misses 274 281 +7
Continue to review full report at Codecov.
|
|
|
||
|
|
||
| model_urls = { | ||
| '_wavernn': 'https://download.pytorch.org/models/_wavernn.pth', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It's conventional to add a FIXME comment here
# FIXME Replace URL by final one once determined
'_wavernn': 'https://download.pytorch.org/models/_wavernn.pth',There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: once you know the actual URL, you can add it here without the underscore in the URL :)
|
Has Linda Johnson consented to voice cloning? Without consent from Linda Johnson, this risks infringing on her personality rights, I think. This could also infringe on her "right to privacy" (the right to be left alone) or "likeness rights". The dataset website does not mention that Linda Johnson was involved in the decision-making process for creating this dataset. I think it'd be important to consider Linda Johnson's perspective before distributing a clone of her voice to the public! Thank you! |
Thank you @PetrochukM for the input! Let me bring @keithito to this discussion. @keithito -- I'm planning to offer pre-trained weights for a WaveRNN model based on LJSpeech in torchaudio. Can you add clarity about whether the license of this dataset allows doing so? Thank you! |
|
Hi @jimchen90, all text and audio in the LJ Speech Dataset is in the public domain. For more information, please see these resources from LibriVox, the project that originally released the recordings:
I have personally corresponded with Linda (the voice actor who read the audiobooks), and she has been very supportive of having her recordings used as the basis of a public domain speech dataset. |
|
Hi @jimchen90! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but we do not have a signature on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thanks for working on it. Is any ETA? |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Continuing this feature in #1612. |
Offer WaveRNN model with pretrained weights (8 bits waveform mode) on LJSpeech using the method as torchvision example.
Related to #735 #749
Internal