Skip to content

Pin SciPy version to 1.4.1 in Windows unittest job #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

Pin SciPy version to 1.4.1 in Windows unittest job #743

merged 1 commit into from
Jun 23, 2020

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Jun 23, 2020 •
edited by vincentqb
Loading

No description provided.

@mthrok mthrok force-pushed the pin-scipy-for-window branch from e5417db to de06f04 Compare June 23, 2020 20:37
@codecov
Copy link

codecov bot commented Jun 23, 2020 •
edited
Loading

Codecov Report

Merging #743 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #743   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files          32       32           
  Lines        2527     2527           
=======================================
  Hits         2249     2249           
  Misses        278      278

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e6ce4...de06f04. Read the comment docs.

@mthrok mthrok requested a review from peterjc123 June 23, 2020 21:03
@mthrok mthrok marked this pull request as ready for review June 23, 2020 21:03
@vincentqb
Copy link
Contributor

vincentqb commented Jun 23, 2020

Fixes #741

vincentqb
vincentqb approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit 37e194f into pytorch:master Jun 23, 2020
@mthrok mthrok deleted the pin-scipy-for-window branch June 23, 2020 22:54
@mthrok
Copy link
Contributor Author

mthrok commented Jun 23, 2020

Thanks

@mthrok mthrok restored the pin-scipy-for-window branch June 23, 2020 23:14
@mthrok mthrok deleted the pin-scipy-for-window branch June 23, 2020 23:34
@vincentqb vincentqb mentioned this pull request Jun 24, 2020
Closed
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
Merge pull request pytorch#743 from drdarshan/master
8dcb9c7 
Add example for distributed launcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterjc123 peterjc123 Awaiting requested review from peterjc123

1 more reviewer

@vincentqb vincentqb vincentqb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mthrok @vincentqb