MelResNet spacing and typing adjustment #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #725 +/- ##
==========================================
- Coverage 89.15% 89.14% -0.01%
==========================================
Files 29 29
Lines 2489 2488 -1
==========================================
- Hits 2219 2218 -1
Misses 270 270
Continue to review full report at Codecov.
|
vincentqb
approved these changes
Jun 17, 2020
torchaudio/models/_wavernn.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| from typing import Optional | |||
| from typing import List | |||
Contributor
There was a problem hiding this comment.
nit: list is not used here (yet), so let's not add it
Contributor
Author
There was a problem hiding this comment.
It has been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to adjust the spacing and typing of melresnet block #705 .