Skip to content

Fix GPU test skip logic #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2020
Merged

Fix GPU test skip logic #516

merged 1 commit into from
Apr 6, 2020

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Apr 6, 2020

test_lfilter_basic_gpu and test_lfilter_gpu were reported as PASSED where there is no GPU, which should be SKIPPED.

@mthrok mthrok requested a review from vincentqb April 6, 2020 19:52
@mthrok mthrok mentioned this pull request Apr 6, 2020
Closed
vincentqb
vincentqb approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentqb vincentqb merged commit f37d37d into pytorch:master Apr 6, 2020
@mthrok mthrok deleted the fix-test-skip branch April 6, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vincentqb vincentqb vincentqb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mthrok @vincentqb