Skip to content

Implementation of RandomCrop for audio #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Implementation of RandomCrop for audio #403

wants to merge 5 commits into from

Conversation

@haideraltahan
Copy link

@haideraltahan haideraltahan commented Jan 12, 2020 •
edited
Loading

Similar to RandomCrop in torchvision. This implementation is for audio given a tensor.
I would've used RandomCrop in torchvision, however, it only takes PIL Image instead of a Tensor.
More on it in #416

@haideraltahan haideraltahan requested review from jamarshon and removed request for vincentqb January 16, 2020 20:16
@haideraltahan haideraltahan mentioned this pull request Jan 16, 2020
Closed
@mthrok
Copy link
Contributor

mthrok commented Aug 3, 2021

Closing the PR as

  1. torchvision's RandomCrop now accepts torch.Tensor
  2. This needs formal specification, as many audio training has corresponding metadata, which also needs to be cropped in the same time steps.

@mthrok mthrok closed this Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamarshon jamarshon Awaiting requested review from jamarshon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haideraltahan @mthrok