Port autograd code for rnnt #3970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3970
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 1 PendingAs of commit ad35a66 with merge base f3e876c ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
reviewed
Jul 11, 2025
NicolasHug
reviewed
Jul 14, 2025
There was a problem hiding this comment.
Thanks for the PR @samanklesaria , this looks good. I still see uses of torch::autograd within src/libtorchaudio/rnnt:
~/dev/audio (port_rnnt*) » git grep autograd src/libtorchaudio/rnnt/ nicolashug@nicolashug-fedora-PF2MMKSN
src/libtorchaudio/rnnt/autograd.cpp: static torch::autograd::tensor_list backward(
src/libtorchaudio/rnnt/autograd.cpp: torch::autograd::AutogradContext* ctx,
src/libtorchaudio/rnnt/autograd.cpp: torch::autograd::tensor_list grad_outputs) {
I suspect these can already be removed? We should try to remove the entire src/libtorchaudio/rnnt/autograd.cpp if we can.
|
Yes, they can be removed. Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.