Skip to content

Port autograd code for rnnt #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 28, 2025
Merged

Port autograd code for rnnt #3970

merged 10 commits into from
Jul 28, 2025

Conversation

samanklesaria
Copy link
Collaborator

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

Copy link

pytorch-bot bot commented Jul 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3970

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 1 Pending

As of commit ad35a66 with merge base f3e876c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@samanklesaria samanklesaria marked this pull request as ready for review July 11, 2025 18:19
@samanklesaria samanklesaria requested a review from a team as a code owner July 11, 2025 18:19
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @samanklesaria , this looks good. I still see uses of torch::autograd within src/libtorchaudio/rnnt:

~/dev/audio (port_rnnt*) » git grep autograd src/libtorchaudio/rnnt/             nicolashug@nicolashug-fedora-PF2MMKSN
src/libtorchaudio/rnnt/autograd.cpp:  static torch::autograd::tensor_list backward(
src/libtorchaudio/rnnt/autograd.cpp:      torch::autograd::AutogradContext* ctx,
src/libtorchaudio/rnnt/autograd.cpp:      torch::autograd::tensor_list grad_outputs) {

I suspect these can already be removed? We should try to remove the entire src/libtorchaudio/rnnt/autograd.cpp if we can.

@samanklesaria
Copy link
Collaborator Author

Yes, they can be removed. Good catch.

@NicolasHug NicolasHug merged commit b2a6973 into main Jul 28, 2025
43 checks passed
@NicolasHug NicolasHug deleted the port_rnnt branch July 28, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants