Skip to content

correct file_obj reference. #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2019
Merged

correct file_obj reference. #352

merged 1 commit into from
Nov 25, 2019

Conversation

@vincentqb
Copy link
Contributor

@vincentqb vincentqb commented Nov 25, 2019 •
edited
Loading

Addressing comment.

@vincentqb vincentqb mentioned this pull request Nov 25, 2019
Merged
@vincentqb
Copy link
Contributor Author

vincentqb commented Nov 25, 2019

Tested with

      def test_download_url(self):
  
          url = "http://www.patentsview.org/data/20171226/botanic.tsv.zip"
          hash_value = "94c642405619b20ecaf657b30e84bab787320649e751ed6ac629c0be613ded44"
          download_folder = "."                                    
  
          from torchaudio.datasets.utils import download_url                                 
          download_url(url, download_folder, hash_value=hash_value)

@vincentqb vincentqb merged commit bdf9255 into pytorch:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangguanheng66 zhangguanheng66 zhangguanheng66 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vincentqb @zhangguanheng66