-
Notifications
You must be signed in to change notification settings - Fork 743
Multi download #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi download #331
Conversation
|
To tests: |
This reverts commit 1369092.
b14bbe8 to
6c1ee4e
Compare
tomassosorio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If list of urls is bigger then list of args will not download all files and will not give any warning
same for **kwargs
Co-authored-by: Tomás Osório <[email protected]>
|
Hi @vincentqb! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Now that python 2 has been deprecated, we want to add parallel download, see comment.
We are using concurrent futures. An alternative would be if this could be fed into
DataLoaderwhich would then take care of the multiprocessing and download.