Skip to content

Conversation

@vincentqb
Copy link
Contributor

@vincentqb vincentqb commented Nov 5, 2019

Now that python 2 has been deprecated, we want to add parallel download, see comment.

We are using concurrent futures. An alternative would be if this could be fed into DataLoader which would then take care of the multiprocessing and download.

@vincentqb vincentqb changed the title Multi download [WIP] Multi download Nov 5, 2019
@vincentqb
Copy link
Contributor Author

To tests:

    def test_download_multiple_url(self):

        url = "http://www.patentsview.org/data/20171226/botanic.tsv.zip"
        url = [url] * 6

        download_folder = "."
        fs = download_url(url, download_folder, hash_value=None)

@vincentqb vincentqb changed the title [WIP] Multi download [To merge after Python 2 deprecation] Multi download Nov 18, 2019
@vincentqb vincentqb changed the title [To merge after Python 2 deprecation] Multi download [Merge after Python 2 deprecation] Multi download Nov 18, 2019
@vincentqb vincentqb changed the title [Merge after Python 2 deprecation] Multi download Multi download Feb 11, 2020
This reverts commit 1369092.
Copy link
Contributor

@tomassosorio tomassosorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If list of urls is bigger then list of args will not download all files and will not give any warning

same for **kwargs

@facebook-github-bot
Copy link
Contributor

Hi @vincentqb!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@mthrok mthrok closed this Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants