Replaced CHECK_ by TORCH_CHECK_ #2582
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHECK_ were deprecated in upstream so we should replace them here as well Signed-off-by: Eli Uriegas <[email protected]> [ghstack-poisoned]
mthrok
approved these changes
Jul 27, 2022
Member
Author
|
ROCm builds are failing since we are behind on ROCm builds on core pytorch nightlies |
Member
Author
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
malfet
approved these changes
Jul 27, 2022
|
Hey @seemethere. |
skim0514
pushed a commit
to skim0514/audio
that referenced
this pull request
Jul 27, 2022
Summary: Pull Request resolved: pytorch#2582 CHECK_ were deprecated in upstream so we should replace them here as well Similar to pytorch/vision#6322, relates to pytorch/pytorch#82032 Signed-off-by: Eli Uriegas <[email protected]> Test Plan: Imported from OSS Reviewed By: malfet, mthrok Differential Revision: D38208356 Pulled By: seemethere fbshipit-source-id: 6f42d517362f415e0775803514eee2628402918f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
CHECK_ were deprecated in upstream so we should replace them here as
well
Similar to pytorch/vision#6322, relates to pytorch/pytorch#82032
Signed-off-by: Eli Uriegas [email protected]
Differential Revision: D38208356