-
Notifications
You must be signed in to change notification settings - Fork 742
add asound for linux. fix deprecated torch type. #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
setup.py
Outdated
|
|
||
| libraries = [] | ||
| if platform.system() == 'Linux': | ||
| libraries = ['asound'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we adding this library? where is it used?
|
soxlib. But maybe we have to explicitly disable alsa when we build sox. I will try that
|
|
I don't think soxlib uses asound. If you look at our packaging build_from_source.sh, those are all the dependencies supported/used by torchaudio for generating our binaries. Perhaps it would be more useful if you create an issue using the issue template with clear steps for reproducing the issue so that we can track it and figure out what is happening |
|
Yes. That was it. sox configure was picking up the lib alsa automatically. The CI image does not have the lib so is not being configured. Excplicity Removed. Explicit is better than implicit. cuda: 10.0.130 |
|
Yes that makes more sense now 😄. @Mistobaan btw, why are you building packages (i.e. conda (.bz2) or pip (.whl))? There are pre-built ones or you can build from source e.g |
|
If I want to contribute to the project. I think is good to be able to build it from scratch :) |
|
Hmm, you don't need to build conda/pip binaries to contribute to the project though. Those are more for distribution. You only need need to build from source. The current packaging scripts are run in a certain environment for the main purpose of generating binaries for release. The scripts are not intended to be the default way for users to install the library |
|
I see what you are saying, but I like to run the CI build script on my environment to spot low hanging errors before the CI does. |
|
friendly ping. anyone that can review this (and few others) PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated PR description. This looks good to me. Thanks!
This reverts commit d26e112.
Uh oh!
There was an error while loading. Please reload this page.