ci: Limit scope of unittest to one python version #2256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limits scope of unittesting to one python version for both macOS and Windows. These types of workflows are particularly expensive and take a long time so running them on every PR / every push is a bit wasteful considering the value in signal between different python versions is probably negligible. Signed-off-by: Eli Uriegas <[email protected]> [ghstack-poisoned]
seemethere
added a commit
that referenced
this pull request
Feb 24, 2022
Limits scope of unittesting to one python version for both macOS and Windows. These types of workflows are particularly expensive and take a long time so running them on every PR / every push is a bit wasteful considering the value in signal between different python versions is probably negligible. Signed-off-by: Eli Uriegas <eliuriegasfb.com> ghstack-source-id: 0e44bf8 Pull Request resolved: #2256
malfet
approved these changes
Feb 24, 2022
Limits scope of unittesting to one python version for both macOS and Windows. These types of workflows are particularly expensive and take a long time so running them on every PR / every push is a bit wasteful considering the value in signal between different python versions is probably negligible. Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
seemethere
added a commit
that referenced
this pull request
Feb 24, 2022
Limits scope of unittesting to one python version for both macOS and Windows. These types of workflows are particularly expensive and take a long time so running them on every PR / every push is a bit wasteful considering the value in signal between different python versions is probably negligible. Signed-off-by: Eli Uriegas <eliuriegasfb.com> ghstack-source-id: c1d95a5 Pull Request resolved: #2256 Signed-off-by: Eli Uriegas <[email protected]>
atalman
approved these changes
Feb 24, 2022
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mthrok
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
LGTM.
I just wanted to note that there were cases where Python version mattered in macOS.
It ultimately boils down to how multiprocessing is used.
https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods
Changed in version 3.8: On macOS, the spawn start method is now the default. The fork start method should be considered unsafe as it can lead to crashes of the subprocess. See bpo-33725.
However, it is more about how the code is using subprocessing, (and it still comes back from time to time) so I agree with the point, not providing much signal.
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: Pull Request resolved: pytorch#2256 Limits scope of unittesting to one python version for both macOS and Windows. These types of workflows are particularly expensive and take a long time so running them on every PR / every push is a bit wasteful considering the value in signal between different python versions is probably negligible. Signed-off-by: Eli Uriegas <[email protected]> Test Plan: Imported from OSS Reviewed By: mthrok Differential Revision: D34459626 Pulled By: seemethere fbshipit-source-id: 47f5c317027f1b395edf9c1720b1b33ba689cad5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Limits scope of unittesting to one python version for both macOS and
Windows. These types of workflows are particularly expensive and take a
long time so running them on every PR / every push is a bit wasteful
considering the value in signal between different python versions is
probably negligible.
Signed-off-by: Eli Uriegas [email protected]
Differential Revision: D34459626