Make torchaudio work on Python 2. #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply __future__ imports uniformly (future division is the biggy, but absolute imports mattered too) - Hotfix use of tempfile.TemporaryDirectory using a BC library (DO NOT add this library as a dependency to torchaudio; it's only for testing) - Replace math.gcd with fractions.gcd - Fix a weird pytest collection bug involving parametrized tests - Turn on Python 2 and Python 3.7 in Travis. Signed-off-by: Edward Z. Yang <[email protected]>
Contributor
Author
|
Implicitly approved in #203 |
jamarshon
added a commit
to jamarshon/audio
that referenced
this pull request
Aug 5, 2019
- Apply __future__ imports uniformly (future division is the biggy, but absolute imports mattered too) - Hotfix use of tempfile.TemporaryDirectory using a BC library (DO NOT add this library as a dependency to torchaudio; it's only for testing) - Replace math.gcd with fractions.gcd - Fix a weird pytest collection bug involving parametrized tests - Turn on Python 2 and Python 3.7 in Travis. Signed-off-by: Edward Z. Yang <[email protected]> (cherry picked from commit a424509)
jamarshon
added a commit
that referenced
this pull request
Aug 5, 2019
jamarshon
added a commit
to jamarshon/audio
that referenced
this pull request
Aug 5, 2019
- Apply __future__ imports uniformly (future division is the biggy, but absolute imports mattered too) - Hotfix use of tempfile.TemporaryDirectory using a BC library (DO NOT add this library as a dependency to torchaudio; it's only for testing) - Replace math.gcd with fractions.gcd - Fix a weird pytest collection bug involving parametrized tests - Turn on Python 2 and Python 3.7 in Travis. Signed-off-by: Edward Z. Yang <[email protected]> (cherry picked from commit a424509)
jamarshon
added a commit
that referenced
this pull request
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__future__imports uniformly (future division is the biggy, but absoluteimports mattered too)
add this library as a dependency to torchaudio; it's only for testing)
Signed-off-by: Edward Z. Yang [email protected]