Packaging improvements for 0.2.0 #199
Conversation
Based off of #198 but nightly specific changes were dropped. Signed-off-by: Edward Z. Yang <[email protected]>
|
|
||
| # build mad, statically | ||
| pushd libmad-0.15.1b | ||
| # See https://stackoverflow.com/a/12864879/23845 |
There was a problem hiding this comment.
if you want, you can use: https://github.com/conda-forge/mad-feedstock/blob/master/recipe/mad.patch
I had issues with clang as well, which need this
There was a problem hiding this comment.
I was able to build wheels after only this change, so that's kind of interesting.
| @@ -1,7 +1,7 @@ | |||
| if [[ ":$PATH:" == *"conda"* ]]; then | |||
There was a problem hiding this comment.
without this, you are prone to accidents. but up to you.
There was a problem hiding this comment.
I am not sure how the accident occurs; the script initializes a fresh conda environment and then sources it?
There was a problem hiding this comment.
if you already have a conda install in path, and you install + source a new conda install, the PATH will have both conda installs at the same time. Then your cmake will find stuff in the first OR the second conda install
There was a problem hiding this comment.
I see. OK I'll bring it back
Based off of #198 but nightly specific changes were dropped.
Signed-off-by: Edward Z. Yang [email protected]