Refactor integration test #1922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make the test support other languages - Fetch tetst asset on-the-fly
| """Smoke test of downloading weights for fine-tuning models and simple transcription""" | ||
| model = bundle.get_model().eval() | ||
| waveform, sample_rate = torchaudio.load(sample_speech_16000_en) | ||
| waveform, sample_rate = torchaudio.load(sample_speech) |
Contributor
There was a problem hiding this comment.
should this take in tmp_path and lang as parameters?
Contributor
Author
There was a problem hiding this comment.
The magic of pytest, which I honestly do not understand very well, will automatically apply lang to sample_speech. Also tmp_path is a fixture pytest will automatically assign.
I am honestly confused but this is how it works.
https://docs.pytest.org/en/6.2.x/example/parametrize.html#apply-indirect-on-particular-arguments
Contributor
There was a problem hiding this comment.
interesting 😮 in that case, lgtm
carolineechen
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #1920