Skip to content

Conversation

@mattip
Copy link
Contributor

@mattip mattip commented Oct 21, 2021

Related to pytorch/text#1416. Minor version became two digits which broke the old code, resulting in docs being pushed to the wrong directory

set -ex
tag=${CIRCLE_TAG:1:5}
# turn v1.12.0rc3 into 1.12.0
tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9.]*\).*/\1/')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upload_docs job is not triggered on release tag (RC or not). (build workflow is not triggered for git tag)

And the build workflow is triggered when a commit is made on release branch, but in this case, there is no tag, because typically tag is pushed separately.

So, to see the effect of this change, first, we need to update the logic around the doc push for release.

I think it should either look into the branch name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mthrok this is true, but one can simulate the behavior by doing something like the following:

 % export CIRCLE_TAG=v0.11.3-rc2
 % echo ${CIRCLE_TAG:1:5}
0.11.
 % echo $(echo $CIRCLE_TAG | sed -e 's/v*\([0-9.]*\).*/\1/')
0.11.3

@malfet malfet merged commit 31dbb75 into pytorch:main Oct 21, 2021
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants