Example code for MuLawDecoding Transform #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nateanl please he to review this PR |
nateanl
requested changes
Aug 6, 2021
Member
nateanl
left a comment
nateanl
left a comment
There was a problem hiding this comment.
LGTM. Just need to fix the nit.
| Args: | ||
| quantization_channels (int, optional): Number of channels. (Default: ``256``) | ||
| Example |
Member
There was a problem hiding this comment.
Let's add a line before Example
Suggested change
| Example | |
| Example |
Member
|
Could you also clean the commit history in the PR? You can do it by rebase to the main branch and force push it. |
nateanl
approved these changes
Aug 6, 2021
Member
nateanl
left a comment
nateanl
left a comment
There was a problem hiding this comment.
LGTM. Next time when you create the PR, could you reset your local branch to the latest main branch? So that we can have only the related commits in the commit history. Thanks! @harishsdev
Contributor
Author
|
git fetch origin above commands are correct,i will reset from next onwards |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example code for MuLawDecoding Transform