Remove fused_log_softmax option from RNNT Loss #1615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineechen
force-pushed
the
rnntl-remove-fused-smax
branch
from
3fbc013 to
77b3082
Compare
carolineechen
force-pushed
the
rnntl-remove-fused-smax
branch
2 times, most recently
from
67d0a19 to
8944d59
Compare
carolineechen
force-pushed
the
rnntl-remove-fused-smax
branch
2 times, most recently
from
ec3d019 to
f7ccf83
Compare
carolineechen
force-pushed
the
rnntl-remove-fused-smax
branch
from
f7ccf83 to
b83afe6
Compare
added 2 commits
August 3, 2021 18:39
carolineechen
force-pushed
the
rnntl-remove-fused-smax
branch
from
b83afe6 to
afa3ec8
Compare
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
…f the missing end `}` (pytorch#1615) * Tiny fix of torch_script_custom_classes custom_op namespace * fix doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: merge after #1610
Remove
fused_log_softmaxoption and keep the behavior of the defaultTrueoption.fused_log_softmax=Falseoption was only relevant whenreuse_logits_for_grads=True, but this behavior is no longer supported after #1610.