[BC-Breaking] Remove lazy behavior from MelScale #1571
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will make changes to the failures soon. |
mthrok
reviewed
Jun 11, 2021
Contributor
mthrok
left a comment
mthrok
left a comment
There was a problem hiding this comment.
Hi @Patil2099
Thanks for working on this. Please refer to my comment for the fix.
mthrok
changed the title
mthrok
reviewed
Jun 21, 2021
hwangjeff
added a commit
that referenced
this pull request
Jul 22, 2021
Rebases #1571; addresses #1569: "In 0.9.0 we are deprecating the lazy behavior of MelScale because it can make an invalid TorchScript object and it does not align with the design of torchaudio. Now in master branch, we can remove the implementation." Co-authored-by: Pankaj Patil <[email protected]> Co-authored-by: moto <[email protected]> Co-authored-by: hwangjeff <[email protected]>
Contributor
|
Addressed in #1636 with credit carried out. Thanks! |
nateanl
pushed a commit
to nateanl/audio
that referenced
this pull request
Jul 28, 2021
Rebases pytorch#1571; addresses pytorch#1569: "In 0.9.0 we are deprecating the lazy behavior of MelScale because it can make an invalid TorchScript object and it does not align with the design of torchaudio. Now in master branch, we can remove the implementation." Co-authored-by: Pankaj Patil <[email protected]> Co-authored-by: moto <[email protected]> Co-authored-by: hwangjeff <[email protected]>
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
* Update prototype_index.rst * Update recipes_index.rst * Update recipes_index.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1569
Closes #851