-
Notifications
You must be signed in to change notification settings - Fork 739
Update skipIfNoCuda decorator/Force GPU tests run in GPU CIs #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @salilsdesai Thanks for working on this. Instead of changing |
.circleci/config.yml.in
Outdated
| - run: | ||
| name: Run tests | ||
| command: docker run -t --gpus all -v $PWD:$PWD -w $PWD "${image_name}" .circleci/unittest/linux/scripts/run_test.sh | ||
| command: docker run -t --gpus all -v $PWD:$PWD -w $PWD "${image_name}" -e "TORCHAUDIO_TEST_FORCE_CUDA=1" .circleci/unittest/linux/scripts/run_test.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-e has to be before "${image_name}"
|
Looks like our CI does have GPU but the firmware is too old. I see a warning Let me see what's the alternative way to install PyTorch. |
|
@salilsdesai Can you leave the Windows as-is for now? The Windows CI situation is somewhat complicated to resolve, so we will tackle later. The you are adding is variable so let's merge it first. |
Oh, you mean I should revert the windows gpu test, right? I'll do that now then. |
Yes, exactly. Thanks for updating it. |
* Recipe for skipping parameter init Co-authored-by: Joel Benjamin Schlosser <[email protected]> Co-authored-by: Brian Johnson <[email protected]>
In response to #1552