remove reuse logits for grads from python interface. #1536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should also make sure to remove this parameter from the tests and c++ source code as well |
|
Closed by comment. The follow-up will need remove both |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
…torch#1536) * Update optimization_tutorial.py * Update quickstart_tutorial.py * Fix typo in optimization tutorial Co-authored-by: suraj813 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1532 (and needs to lands after #1532)
The default for
reuse_logits_for_grads=Truecan also be confusing to users and lead to the inputs being modified in place.I’ll simply remove this option for now.