[#1511] Add deprecation warning to MelScale for unset weight #1515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue a warning if `n_stft` is unitialized or zero in construction. pytorch#1511
|
Rebased and pushed with PR feedback. |
mthrok
approved these changes
May 19, 2021
Co-authored-by: moto <[email protected]>
Co-authored-by: moto <[email protected]>
|
Argh, sorry I missed those, they were pretty obvious. |
mthrok
approved these changes
May 19, 2021
|
Thanks! |
2 tasks
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Holly Sweeney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue a warning if
n_stftis unitialized or zero in construction.#1511