ISTFT #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cpuhrsch merged 37 commits into pytorch:master from jamarshon:istft

Jul 10, 2019

Contributor

jamarshon commented Jul 10, 2019

Inverse STFT (#130). Can't reopen previous one so here it is again

jamarshon added 28 commits

July 3, 2019 09:35


          first

95a810f


          add tests

0a8386c


          more test

5f48c98


          remove print

1d2cbed


          abs min instead of min

6107f65


          apply feedback

050ae23


          apply feedback

690fe92


          flake8

1e2f949


          apply feedback

ee20335


          apply feedback

7242e7b


          apply feedback

50a6f3e


          fix test_transforms.py. pytorch nightly must have changed from_numpy …

38c94b7

…or something


          apply feedback

60ae1bb


          apply feedback

1c56a06


          apply feedback

fe001e1


          apply feedback

8427a89


          flake8

80255af


          apply feedback

1d79b54


          apply feedback

2f36eb7


          test

21c95a2


          test

dd2b838


          done

a0de40d


          apply feedback

d2a72e6


          apply feedback

6a9ef42


          apply feedback

fc57968


          revert files

d8bbb8d


          apply feedback

92801d5


          jMerge branch 'master' into istft

03c0fe2

cpuhrsch requested a review from vincentqb

July 10, 2019 16:09

cpuhrsch reviewed

View reviewed changes

test/test_functional.py Outdated Show resolved Hide resolved

cpuhrsch requested changes

View reviewed changes

Contributor

cpuhrsch left a comment

Please see comment

cpuhrsch reviewed

View reviewed changes

test/test_functional.py Outdated Show resolved Hide resolved

cpuhrsch reviewed

View reviewed changes

test/test_functional.py Outdated Show resolved Hide resolved

cpuhrsch reviewed

View reviewed changes

test/test_functional.py Outdated Show resolved Hide resolved

cpuhrsch reviewed

View reviewed changes

test/test_functional.py Outdated Show resolved Hide resolved


          apply feedback

f8d97da

cpuhrsch reviewed

View reviewed changes

test/test_functional.py Outdated Show resolved Hide resolved

jamarshon added 2 commits

July 10, 2019 10:30


          apply feedback

9cd6ee6


          apply feedback

025f4ef

cpuhrsch reviewed

View reviewed changes

test/test_functional.py Outdated Show resolved Hide resolved

cpuhrsch reviewed

View reviewed changes

test/test_functional.py Outdated Show resolved Hide resolved

jamarshon added 2 commits

July 10, 2019 10:49


          apply feedback

335bf81


          apply feedback

39c93d2

Contributor

vincentqb commented Jul 10, 2019

What are the differences with #130?

cpuhrsch reviewed

View reviewed changes

test/common_utils.py Outdated Show resolved Hide resolved

jamarshon added 2 commits

July 10, 2019 11:16


          apply feedback

50b5743


          apply feedback

78ebf7a

cpuhrsch reviewed

View reviewed changes

test/common_utils.py Outdated Show resolved Hide resolved


          apply feedback

f7fddea

cpuhrsch reviewed

View reviewed changes

test/test_functional.py Show resolved Hide resolved


          apply feedback

a41a6a0

cpuhrsch approved these changes

View reviewed changes

Contributor

cpuhrsch left a comment

LGTM

cpuhrsch merged commit 56e2835 into pytorch:master

jamarshon deleted the istft branch

July 10, 2019 19:22

vincentqb pushed a commit to vincentqb/audio that referenced this pull request


          ISTFT (pytorch#135)

a0b9634

zhanwenchen mentioned this pull request

istft: torch.eye dtype conforms to stft_matrix. #286

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet