torchaudio: Fix c extension compilation #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a9f5e7229 was merged into upstream pytorch the passing of references within torch c extension functions is no longer allowed. This just removes the reference and passes by value instead. Signed-off-by: Eli Uriegas <[email protected]>
vincentqb
approved these changes
Feb 19, 2021
|
cc #1282 |
samestep
approved these changes
Feb 19, 2021
seemethere
added a commit
to seemethere/audio
that referenced
this pull request
Feb 19, 2021
This reverts commit a70931f.
|
This feels better resolved like D26138549. |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pytorch/pytorch@a9f5e72 was merged into upstream pytorch the passing of
references within torch c extension functions is no longer allowed. This
just removes the reference and passes by value instead.
Signed-off-by: Eli Uriegas [email protected]