Skip to content

Add Python 3.9 support #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 19, 2021
Merged

Add Python 3.9 support #1242

merged 7 commits into from
Feb 19, 2021

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Feb 5, 2021

(cherry picked from commit 1b7ee83)
Signed-off-by: Eli Uriegas [email protected]

@mthrok mthrok mentioned this pull request Feb 5, 2021
Closed
@mthrok mthrok added this to the v0.8 milestone Feb 5, 2021
@mthrok
Copy link
Contributor

mthrok commented Feb 5, 2021

@seemethere

there are flaky tests. If you see tests like the following, you can ignore them.

test_bytesio_3_flac
test_bytesio_4_flac
test_bytesio_5_flac
test_fileobj_3_flac
test_fileobj_4_flac
test_fileobj_5_flac

@mthrok mthrok mentioned this pull request Feb 10, 2021
Closed
@mthrok mthrok linked an issue Feb 10, 2021 that may be closed by this pull request
torchaudio wheel for Python3.9, torch 1.8.0, and cuda 11. #1257
Closed
@seemethere seemethere force-pushed the python39_master branch 8 times, most recently from 0fc9f08 to e6e7c07 Compare February 10, 2021 22:41
@seemethere seemethere force-pushed the python39_master branch 2 times, most recently from b88566e to d116982 Compare February 18, 2021 22:00
@seemethere
Add Python 3.9 support
3a85b79 
(cherry picked from commit 1b7ee83)
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
do the same thing for windows
7c1e79d 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
derive python version from actual python
c8e7cdf 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
do python check with python, just regular comparison
4f105ed 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
ensure we're installing pytorch from the correct channel
a3c4e70 
conda channel priorities strike again, they're so unpredictable

Signed-off-by: Eli Uriegas <[email protected]>
@seemethere seemethere marked this pull request as ready for review February 19, 2021 19:20
This was referenced Feb 19, 2021
Closed
Merged
vincentqb
vincentqb approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll merge once the tests are done, and cherry-pick it for the release branch.

@vincentqb vincentqb merged commit eb1b3f1 into pytorch:master Feb 19, 2021
@seemethere seemethere deleted the python39_master branch February 19, 2021 19:31
vincentqb pushed a commit that referenced this pull request Feb 19, 2021
@seemethere @vincentqb
Add Python 3.9 support (#1242)
d560639 
Signed-off-by: Eli Uriegas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mthrok mthrok Awaiting requested review from mthrok

1 more reviewer

@vincentqb vincentqb vincentqb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

v0.8

Development

Successfully merging this pull request may close these issues.

torchaudio wheel for Python3.9, torch 1.8.0, and cuda 11.

4 participants

@seemethere @mthrok @vincentqb @facebook-github-bot