Skip to content

Conversation

@marc-moreaux
Copy link

In their paper https://arxiv.org/abs/1711.10282, the authors use 2D convolution of monoChannel raw audio sounds with some data augmentation like stretching the sound, randomly cropping a piece of sound and padding the sound on both extremities to allow random crops on the borders

@cpuhrsch cpuhrsch requested a review from jamarshon June 17, 2019 14:31
return self.__class__.__name__ + '()'


class Pad(object):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class seems very similar to PadTrim (

class PadTrim(object):
).
Is there any difference?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not look like. They bot end up using the same torch.functional.pad function.

@Mistobaan
Copy link
Contributor

Would be nice to merge those extra utility functions @marc-moreaux

Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There seems to be a significant overlap with existing transforms though, and it's not clear to me which of these transformations would be a non-trivial and useful addition.

return crop_in_between(tensor, start.item(), end.item(), ch_dim)


def stretch(tensor, factor, interpolate, ch_dim):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this similar to Resample or phase_vocoder?

@vincentqb
Copy link
Contributor

Since this PR is out of date and contains significant overlap with existing features, I will close this PR. Please feel free to open a new issue to discuss the transforms you would like to add within torchaudio so we can discuss how to proceed.

@vincentqb vincentqb closed this Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants