-
Notifications
You must be signed in to change notification settings - Fork 738
Apply codec-based data augmentation #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3677399
add initial commit
AzizCode92 9165a4d
fix linting
AzizCode92 4767017
update unit-test
AzizCode92 4f004a8
Revert "fix linting"
AzizCode92 329e28b
update decorator
AzizCode92 cd5f077
update unit-test
AzizCode92 5caf1a8
fix unit-test
AzizCode92 cd2688e
fix typo
AzizCode92 9cccf45
fix windows unit-test
AzizCode92 93115b5
fix linting of the unit-test
AzizCode92 f97241e
add docstring to apply_codec
AzizCode92 fa56682
Update docs + unittest
AzizCode92 9a7a575
Merge branch 'master' into codec_augmentation
AzizCode92 f6f9b8d
feat: fix unit-test + update docs
AzizCode92 f470175
feat: add test for torchScript consistency
AzizCode92 c887d25
Merge branch 'master' into codec_augmentation
AzizCode92 917dd63
fix: remove torchscript consistency test
AzizCode92 7ccd317
Merge branch 'master' into codec_augmentation
AzizCode92 1576215
feat: add apply_codec to consistency_impl
AzizCode92 e8ace1d
fix: fix linting issues
AzizCode92 ba9c4aa
Merge branch 'master' into codec_augmentation
AzizCode92 ec8326e
feat: update docstring and unit-test
AzizCode92 f858dd7
fix: remove unecessary test
AzizCode92 43b2e65
fix: update docstring
AzizCode92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reorder the parameters as
waveform, sample_rate, channels_first, format, encoding, bits_per_sample?Sorry I am reverting what I originally asked (moving
channels_firstafterformat) but grouping format related parameters together looks nicer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the
channels_first(default_parameter) beforeformat(non default_parameter) throws a syntax-errorSyntaxError: non-default argument follows default argument.Also what about the
compressionparameter?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I made an invalid suggestion again.
let's do
waveform, sample_rate, format, channels_first, compression, encoding, bits_per_sample