Switch to cmake for build #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
cmake
branch
4 times, most recently
from
77d4816 to
5ca8a2a
Compare
mthrok
added a commit
that referenced
this pull request
Jan 21, 2021
Changing the test Docker image for GPU tests to use Nvidia Docker `devel` image. This is necessary for #1187.
mthrok
force-pushed
the
cmake
branch
5 times, most recently
from
08320b8 to
63b2374
Compare
mthrok
force-pushed
the
cmake
branch
5 times, most recently
from
38ed382 to
3bca1d1
Compare
mthrok
force-pushed
the
cmake
branch
2 times, most recently
from
7465ad7 to
80edff1
Compare
cpuhrsch
reviewed
Feb 4, 2021
| ENDIF() | ||
|
|
||
| ADD_LIBRARY(warprnnt STATIC submodule/src/rnnt_entrypoint.cpp) | ||
| add_library(warprnnt STATIC submodule/src/rnnt_entrypoint.cpp) |
Contributor
There was a problem hiding this comment.
We should probably also hide warprnnt symbols
Contributor
Author
There was a problem hiding this comment.
I misspoke during the review. -fvisibility=hidden is defined on third_party level so it is propagated to transducer module too.
$ objdump -t build/temp.linux-x86_64-3.8/third_party/transducer/libwarprnnt.a | grep hidden
0000000000000000 g F .text 0000000000000006 .hidden get_warprnnt_version
0000000000000010 g F .text 0000000000000038 .hidden rnntGetStatusString
0000000000000050 g F .text 000000000000005e .hidden get_workspace_size
0000000000000000 w F .text._ZN7CpuRNNTIfE14compute_alphasEPKfiiPf 00000000000002b8 .hidden _ZN7CpuRNNTIfE14compute_alphasEPKfiiPf
0000000000000000 w F .text._ZN7CpuRNNTIdE14compute_alphasEPKdiiPd 000000000000029d .hidden _ZN7CpuRNNTIdE14compute_alphasEPKdiiPd
0000000000000000 w F .text._ZN7CpuRNNTIfE22compute_betas_and_gradEPfPKfiiS1_S1_PKif 00000000000008fd .hidden _ZN7CpuRNNTIfE22compute_betas_and_gradEPfPKfiiS1_S1_PKif
0000000000000000 w F .text._ZN7CpuRNNTIfE13cost_and_gradEPKfPfS3_PKiS5_S5_ 000000000000051f .hidden _ZN7CpuRNNTIfE13cost_and_gradEPKfPfS3_PKiS5_S5_
00000000000000b0 g F .text 0000000000000610 .hidden compute_rnnt_loss
0000000000000000 w F .text._ZN7CpuRNNTIdE22compute_betas_and_gradEPdPKdiiS1_S1_PKid 00000000000008b7 .hidden _ZN7CpuRNNTIdE22compute_betas_and_gradEPdPKdiiS1_S1_PKid
0000000000000000 w F .text._ZN7CpuRNNTIdE13cost_and_gradEPKdPdS3_PKiS5_S5_ 00000000000004c4 .hidden _ZN7CpuRNNTIdE13cost_and_gradEPKdPdS3_PKiS5_S5_
00000000000006c0 g F .text 00000000000005f0 .hidden compute_rnnt_loss_fp64
0000000000000000 *UND* 0000000000000000 .hidden __dso_handle
Contributor
Author
There was a problem hiding this comment.
The thing is that, to build libsox, we use ExternalProject_Add which does not reflect the regular CMake configuration like CMAKE_CXX_FLAGS so it has to be set again there.
cpuhrsch
reviewed
Feb 4, 2021
torchaudio/csrc/CMakeLists.txt
Outdated
| ################################################################################ | ||
| # _torchaudio.so | ||
| ################################################################################ | ||
| if (BUILD_PYTHON_EXTENSION) |
Contributor
There was a problem hiding this comment.
suggestion: I'd go with BUILD_TORCHAUDIO_PYTHON_EXTENSION just because this is quite generic
cpuhrsch
approved these changes
Feb 4, 2021
Contributor
Author
|
THANK YOU! |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
Co-authored-by: Brian Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1068