Support file-like object in apply_effects_file #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mthrok
force-pushed
the
file-like-obj-sox-effects
branch
2 times, most recently
from
cc0ece0 to
ae837ec
Compare
mthrok
force-pushed
the
file-like-obj-sox-effects
branch
from
ae837ec to
4a85493
Compare
mthrok
force-pushed
the
file-like-obj-sox-effects
branch
from
4a85493 to
d8f8784
Compare
|
thanks! |
|
@vincentqb that failure is not originated from this. It is flaky in the occurrence but the same set of tests fail when it happens. I am hunting down the cause. and current hypothesis is that the underlying CCI environment is not consistent. Anyways it does not block the import you are working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying implementation is same as
loadfunction. (both useapply_effects_fileobj) So this is just registering the C++ implementations, modifying frontend and adding test.See also #1115