-
Notifications
You must be signed in to change notification settings - Fork 738
Remove redundant dataset utilities #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for working on this but you need to get rid of all the internal use. |
|
Hi, @mthrok looks like I am missing some context. Can you please let me know why |
|
These utilities were added (for internal use) to ease the difference between Python 2 and Python 3. But now that Python 2 support is officially dropped, we do not need these utilities. Instead we can use the standard module as-is. So we just need to replace the usages of these functions with standard module. Then we can remove the utility functions themselves. |
5908fc7 to
e987525
Compare
|
@mthrok can you please review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you so much!
|
@mthrok can you please recommend some other (easy - medium complexity) issues that I could work on?. Cheers, |
|
@krishnakalyan3 Sure. Thanks for offering :) Let me think of an issue. Meanwhile, if you can join PyTorch's slack channel, we can discuss collaboration there too. Communication will be faster that way. https://pytorch.org/resources/ |
|
How about #910 (comment) ? |
* fix device mismatch issue pytorch#1071 * fix device mismatch issue pytorch#1071 * add mnist_rnn to test script for CI * support dry_run in test()
I have also addressed your comments on torch.random #1022 (comment).
Fixes #1081