Add pathlib.Path support all io

[vincentqb]

Since pathlib is the standard python library for handling paths since python 3.4, let's add explicit support for pathlib in i/o operations.

• sox_io
• sox (won't update)
• "new" soundfile
• legacy sox (won't update)
• apply_effects_file, here, jit does not support union, see comment

There are also datasets who consume paths as string in their constructor, which could be extended to pathlib. (This means adding a conversion at the beginning of each function to convert path to string so the rest can proceed as expected.)

• cmuarctic
• commonvoice
• gtzan
• librispeech
• libritts
• ljspeech
• speechcommands
• tedlium
• vctk
• yesno
• see dataset utils consuming a path here

cc offline discussion with @mthrok and @cpuhrsch about #907

[mthrok]

Can you share the list of action items for this?

Note that "sox_io" backend and the new interface of "soundfile" backend support path lib.Path already, so no need to change the implementation.

Since we are getting rid of "sox" backend and the legacy interface of "soundfile" backend, I would not put them on a high priority, rather I would leave them as is.

[vincentqb]

Note that "sox_io" backend and the new interface of "soundfile" backend support path lib.Path already, so no need to change the implementation.

Since we are getting rid of "sox" backend and the legacy interface of "soundfile" backend, I would not put them on a high priority, rather I would leave them as is.

Agree.

Can you share the list of action items for this?

The datasets, and apply_effects_file are the other places were files are being used. That's all I can think of. Some/All may already support, we should just double check :) Any others?

(updated description)

[mthrok]

Can you clarify on what actions are needed for each component?

apply_effects_file makes sense and I was not aware so thanks for listing up, however, it is not immediately clear to me why dataset implementations are on the list. They are not responsible for I/O, nor they receive path from client code.

[vincentqb]

I'm referring to the parameters in the constructor, .e.g root which is a string, but really a path.

[mthrok]

I'm referring to the parameters in the constructor, .e.g root which is a string, but really a path.

ah make sense. Thanks for the clarification.