Skip to content

Conversation

@crcrpar
Copy link
Contributor

@crcrpar crcrpar commented Oct 1, 2024

as I didn't see the strong reason to exclude it from the slots

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/984

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit c0a304b with merge base d4b2f33 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2024
@jerryzh168 jerryzh168 requested review from drisspg and vkuzo October 1, 2024 16:18
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

TBH these slots don't end up being super helpful since technically this breaks Liskov substitution for torch.Tenor

@msaroufim
Copy link
Member

msaroufim commented Oct 10, 2024

@crcrpar wanna fix the lint so i can merge?

@crcrpar crcrpar force-pushed the float8tensor_slots-gemm-role branch from 4546ad6 to a0b629f Compare October 11, 2024 04:13
@msaroufim
Copy link
Member

I just made the lint

@msaroufim msaroufim merged commit e6ceb95 into pytorch:main Oct 12, 2024
10 of 14 checks passed
@crcrpar crcrpar deleted the float8tensor_slots-gemm-role branch October 12, 2024 00:47
jainapurva pushed a commit that referenced this pull request Oct 15, 2024
* add "_gemm_input_role" to dunder slots

Signed-off-by: Masaki Kozuki <[email protected]>

* lint

---------

Signed-off-by: Masaki Kozuki <[email protected]>
Co-authored-by: Mark Saroufim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants