Fix fake fusion for convolutions without bias #3353
+20
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3353
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ddfbfd3 with merge base 4f5bc7a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@balakrishnanv has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87356763. |
balakrishnanv
pushed a commit
to balakrishnanv/ao
that referenced
this pull request
Nov 20, 2025
Summary: Pull Request resolved: pytorch#3353 Fix `AttributeError` when performing fake fusion on convolution layers without bias by creating a zero-filled bias parameter instead of attempting to access requires_grad on None. Differential Revision: D87356763
balakrishnanv
force-pushed
the
export-D87356763
branch
2 times, most recently
from
d6cbf8a to
14e37fc
Compare
balakrishnanv
pushed a commit
to balakrishnanv/ao
that referenced
this pull request
Nov 20, 2025
Summary: Fix `AttributeError` when performing fake fusion on convolution layers without bias by creating a zero-filled bias parameter instead of attempting to access requires_grad on None. Differential Revision: D87356763
balakrishnanv
pushed a commit
to balakrishnanv/ao
that referenced
this pull request
Nov 20, 2025
Summary: Fix `AttributeError` when performing fake fusion on convolution layers without bias by creating a zero-filled bias parameter instead of attempting to access requires_grad on None. Differential Revision: D87356763
balakrishnanv
force-pushed
the
export-D87356763
branch
from
14e37fc to
12f1d7f
Compare
balakrishnanv
pushed a commit
to balakrishnanv/ao
that referenced
this pull request
Nov 20, 2025
Summary: Fix `AttributeError` when performing fake fusion on convolution layers without bias by creating a zero-filled bias parameter instead of attempting to access requires_grad on None. Differential Revision: D87356763
balakrishnanv
force-pushed
the
export-D87356763
branch
2 times, most recently
from
ab0a21f to
6c3efa5
Compare
Summary: Fix `AttributeError` when performing fake fusion on convolution layers without bias by creating a zero-filled bias parameter instead of attempting to access requires_grad on None. Reviewed By: jerryzh168 Differential Revision: D87356763
balakrishnanv
force-pushed
the
export-D87356763
branch
from
6c3efa5 to
ddfbfd3
Compare
jerryzh168
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix
AttributeErrorwhen performing fake fusion on convolution layers without bias by creating a zero-filled bias parameter instead of attempting to access requires_grad on None.Differential Revision: D87356763