update roofline benchmark with mxfp4 #3152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
vkuzo
added a commit
that referenced
this pull request
Oct 10, 2025
Summary: For now, update the roofline part only. We can add support to the benchmarks in a future PR. Test Plan: ```bash python benchmarks/float8/float8_roofline.py ~/local/tmp/20251010_mxfp4_cutlass_roofline.csv --mx_recipe_name mxfp4_cutlass --do_benchmarks False --shape_gen_name pow2_extended ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 790b0c8 ghstack-comment-id: 3392201674 Pull-Request: #3152
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3152
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 33e7f81 with merge base 29f6758 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
vkuzo
added
the
topic: not user facing
drisspg
reviewed
Oct 10, 2025
| if fuse_with_prev: | ||
| kernel_1_rw = 0 + BYTES_PER_EL_FLOAT8 * numel | ||
| if mx_recipe_name == "mxfp4_cutlass": | ||
| if fuse_with_prev: |
Contributor
There was a problem hiding this comment.
fuse_with_prev is 1 of the two casts is fused but not the other?
drisspg
approved these changes
Oct 10, 2025
namgyu-youn
pushed a commit
to namgyu-youn/ao
that referenced
this pull request
Nov 21, 2025
Update [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For now, update the roofline part only. We can add support to the
benchmarks in a future PR.
Test Plan:
python benchmarks/float8/float8_roofline.py ~/local/tmp/20251010_mxfp4_cutlass_roofline.csv --mx_recipe_name mxfp4_cutlass --do_benchmarks False --shape_gen_name pow2_extendedReviewers:
Subscribers:
Tasks:
Tags: