Skip to content

Conversation

@danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Jul 30, 2025

Stacked PRs:


backward pass for differentiable mxfp8 grouped gemm with dynamic quant

Summary

  • Add backward pass
  • Add unit tests verifying numerical accuracy

Test plan

  • pytest test/prototype/moe_training/test_scaled_grouped_mm.py

stack-info: PR: #2639, branch: danielvegamyhre/stack/25
danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2639, branch: danielvegamyhre/stack/25
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2639

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/25 branch from f866e23 to 7a8b843 Compare July 30, 2025 22:13
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2025
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jul 30, 2025
@danielvegamyhre
Copy link
Contributor Author

@vkuzo @drisspg for review

@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/24 to main July 30, 2025 23:19
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/24 July 30, 2025 23:19
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/24 to main July 31, 2025 17:24
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/24 July 31, 2025 17:24
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/24 to main July 31, 2025 17:33
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/24 July 31, 2025 17:33
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/24 to main July 31, 2025 22:31
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/24 July 31, 2025 22:31
)

# Check weight grads
min_weight_grad_sqnr = 24.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/24 to main August 1, 2025 18:36
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/25 branch from 7a8b843 to e9ba18b Compare August 1, 2025 18:37
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/24 August 1, 2025 18:37
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/25 branch from e9ba18b to 2aabb15 Compare August 1, 2025 20:18
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/24 to main August 1, 2025 20:18
@danielvegamyhre danielvegamyhre merged commit 1f0d2bb into main Aug 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. moe topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants