Skip to content

Fix experimental CI #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2025
Merged

Fix experimental CI #1820

merged 2 commits into from
Mar 3, 2025

Conversation

@metascroy
Copy link
Contributor

@metascroy metascroy commented Mar 3, 2025

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1820

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Pending

As of commit 2ec42b2 with merge base 914de78 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2025
@metascroy metascroy requested a review from drisspg March 3, 2025 21:47
@metascroy metascroy added the ci label Mar 3, 2025
@metascroy metascroy merged commit bc54ae5 into main Mar 3, 2025
16 of 18 checks passed
@drisspg drisspg added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 3, 2025
kimishpatel
kimishpatel reviewed Mar 3, 2025
View reviewed changes
torchao/experimental/ops/tests/test_linear_8bit_act_xbit_weight.cpp
}
for (int i = 0; i < m * n; i++) {
EXPECT_NEAR(output[i], test_case.expected_output[i], kTol);
EXPECT_NEAR(output[i], test_case.expected_output[i], tol);
Copy link
Contributor

@kimishpatel kimishpatel Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow. Dont know what happend to reduce tol

Copy link
Contributor Author

@metascroy metascroy Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anything happened.

I guess the KleidiAI kernels never consistently passed the tests with the existing tolerance; they only pass about 7 out of every 8 times you run the tests (@digantdesai confirmed this). But I didn't realize this until I enabled them in CI.

Reducing tolerance makes them consistently pass (at least I didn't see any failures locally when I repeatedly ran the tests).

We still need to figure out why they don't consistently pass at the higher tolerance.

liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
@metascroy @liangel-02
Fix experimental CI (#1820)
f2bfc17 
* up

* up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimishpatel kimishpatel kimishpatel left review comments

@drisspg drisspg drisspg approved these changes

Assignees

No one assigned

Labels

ci CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@metascroy @kimishpatel @drisspg @facebook-github-bot