-
Notifications
You must be signed in to change notification settings - Fork 375
Silence loud error on torchao cpu builds #1808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1808
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 11 PendingAs of commit 77e2b3f with merge base 7963f9c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Errors seem like flakes |
|
|
||
| from torchao.utils import TORCH_VERSION_AT_LEAST_2_2, TORCH_VERSION_AT_LEAST_2_6 | ||
|
|
||
| logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its recommend to have null handlers for library logging
logger = logging.getLogger(__name__)
logger.addHandler(logging.NullHandler())And then users can turn them on w/
https://github.com/drisspg/transformer_nuggets/blob/d04895f4adb17a7db1cd99be405019501dcb3ecf/transformer_nuggets/__init__.py#L4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`
* Silence loud commit * Update intmm.py
before this fix, just importing torchao in a cpu only environment would print
import error: triton not foundCame up live in this talk by @manuelcandales https://www.youtube.com/watch?v=0vv9K0RvOfo&ab_channel=GPUMODE
To repro on your M1 laptop